Treat narrowing conversion as warning, not error #38
Conversation
There was a problem hiding this comment.
Looks good to me. I do wonder if we need some kind of mechanism or preference to disable this kind of compatibility fixes, so users and library authors can opt-in on getting the most thorough checking of their code, but that's probably a different discussion.
|
This doesn't remove the message. It still shows as warning messages, just not errors. The problem is so many library authors never change Arduino default to suppress all warnings, so they never know their code has warnings. I believe arduino-builder could implement some logic to detect if timestamps on library files are newer than the sketch source, or newer than other stuff (maybe the library.properties or src folder or....) the idea would be to detect when someone is editing the library files rather than just using a freshly installed copy. It's the library is being edited, maybe turn on all warnings. Doing this might improve the library quality across the entire Arduino ecosystem over time? |
Wow, this is a very clever idea! One very simple first step could be activating warnings by default on libraries that are actually versioned (contain a .git folder? ) |
Fix for arduino/Arduino#7944
Before the upgrade to gcc 5.4, this was treated as a non-fatal warning (when warnings are enabled). Now some libraries fail to compile. This simply restores the gcc 4.8 & 4.9 behavior.